Force background color to white, not transparent#141
Open
stoyle wants to merge 1 commit intofabric-ds:nextfrom
Open
Force background color to white, not transparent#141stoyle wants to merge 1 commit intofabric-ds:nextfrom
stoyle wants to merge 1 commit intofabric-ds:nextfrom
Conversation
Contributor
|
This breaks hover styling on the checkbox. |
Author
|
Oh wow, that's interesting! Good catch. Seems specificity is higher on the "regular" ::before styling, than with hover. Creating a custom hover style for this case should be even more specific... But too complicated for such a small thing? We can fix this with a custom selector in our podlet. |
Author
|
This fixes it for us: https://github.schibsted.io/finn/extended-profile-podium/commit/1b5e2f2bfa6cc43770e25498c1ab509612ae37ab I still think this should live in fabric, not in our repo. But that is of course up to the fabric team. By the way, the check mark is visible when hovering, but I guess that's a feature 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #140